feat(cache): add LLM metadata caching for model and provider information #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 17, 2025
Pouyanpi
force-pushed
the
feat/cache-interface-cleanup
branch
from
053cd1c to
cb827ae
Compare
Pouyanpi
force-pushed
the
feat/cache-llm-metadata
branch
from
b05cac4 to
e725d77
Compare
tgasser-nv
approved these changes
Oct 17, 2025
Collaborator
tgasser-nv
left a comment
tgasser-nv
left a comment
There was a problem hiding this comment.
Looks good, just a few cleanup nits in the tests to address before merging
Extends the cache system to store and restore LLM metadata (model name and provider name) alongside cache entries. This allows cached results to maintain provenance information about which model and provider generated the original response. - Added LLMMetadataDict and LLMCacheData TypedDict definitions for type safety - Extended CacheEntry to include optional llm_metadata field - Implemented extract_llm_metadata_for_cache() to capture model and provider info from context - Implemented restore_llm_metadata_from_cache() to restore metadata when retrieving cached results - Updated get_from_cache_and_restore_stats() to handle metadata extraction and restoration - Added comprehensive test coverage for metadata caching functionalit
…, refactor LLMCallInfo instantiation
Pouyanpi
force-pushed
the
feat/cache-llm-metadata
branch
from
e725d77 to
fd873b7
Compare
Pouyanpi
added a commit
that referenced
this pull request
Oct 28, 2025
…ion (#1456) * feat(cache): add LLM metadata caching for model and provider information Extends the cache system to store and restore LLM metadata (model name and provider name) alongside cache entries. This allows cached results to maintain provenance information about which model and provider generated the original response. - Added LLMMetadataDict and LLMCacheData TypedDict definitions for type safety - Extended CacheEntry to include optional llm_metadata field - Implemented extract_llm_metadata_for_cache() to capture model and provider info from context - Implemented restore_llm_metadata_from_cache() to restore metadata when retrieving cached results - Updated get_from_cache_and_restore_stats() to handle metadata extraction and restoration - Added comprehensive test coverage for metadata caching functionalit * address review comments: add _s suffix to durations, add test fixture, refactor LLMCallInfo instantiation
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 28, 2025
…ion (#1456) * feat(cache): add LLM metadata caching for model and provider information Extends the cache system to store and restore LLM metadata (model name and provider name) alongside cache entries. This allows cached results to maintain provenance information about which model and provider generated the original response. - Added LLMMetadataDict and LLMCacheData TypedDict definitions for type safety - Extended CacheEntry to include optional llm_metadata field - Implemented extract_llm_metadata_for_cache() to capture model and provider info from context - Implemented restore_llm_metadata_from_cache() to restore metadata when retrieving cached results - Updated get_from_cache_and_restore_stats() to handle metadata extraction and restoration - Added comprehensive test coverage for metadata caching functionalit * address review comments: add _s suffix to durations, add test fixture, refactor LLMCallInfo instantiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the cache system to store and restore LLM metadata (model name and provider name) alongside cache entries. This allows cached results to maintain provenance information about which model and provider generated the original response.
Changes
LLMMetadataDictandLLMCacheDataTypedDict definitions for type safetyCacheEntryto include optionalllm_metadatafieldextract_llm_metadata_for_cache()to capture model and provider info from contextrestore_llm_metadata_from_cache()to restore metadata when retrieving cached resultsget_from_cache_and_restore_stats()to handle metadata extraction and restorationDependencies
Part of Stack
This is PR 2/5 in the NeMoGuards caching feature stack.